Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add full width to dashboard player and adjust other live views #374

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Mebareksaf
Copy link
Contributor

Screenshot 2024-02-14 at 4 55 59 AM

Screenshot 2024-02-14 at 4 56 05 AM

@Mebareksaf Mebareksaf added the ui related to UI label Feb 14, 2024
@Mebareksaf Mebareksaf self-assigned this Feb 14, 2024
@gBillal
Copy link
Member

gBillal commented Feb 23, 2024

This is too much, you can't even see the whole video without scrolling.

@Mebareksaf
Copy link
Contributor Author

This is too much, you can't even see the whole video without scrolling.

Shall i only make it take full-width and not length?

@marcoherbst
Copy link
Member

Maybe you guys know this, but what you're looking for is 'fit to screen' . Like most players and today's evercam , the video will fit to whichever the limiting dimension happens to be. Open google meet and play with the window size, you will see how it works. (or evercam player)

@gBillal
Copy link
Member

gBillal commented Feb 23, 2024

Shall i only make it take full-width and not length?

Try to use the available height and let the width grow accordingly.

@Mebareksaf
Copy link
Contributor Author

Mebareksaf commented Feb 27, 2024

@gBillal i've adjusted it to fill the smallest viewport screen height "h-svh"

Screenshot 2024-02-27 at 2 46 40 AM Screenshot 2024-02-27 at 2 46 33 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui related to UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants