Do not show charts at the end, close charts after being used #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 104 alerts when merging d35b66f into a156a28 - view on LGTM.com new alerts:
|
|
This pull request introduces 4 alerts when merging d35a61e into f1ed847 - view on LGTM.com new alerts:
|
|
This pull request introduces 4 alerts when merging ad90868 into f1ed847 - view on LGTM.com new alerts:
|
|
@jwasinger I created a Dockerfile to generate the charts in a docker instance, but it is generating the exact same files (no diff), I'll take a closer look at the CI and maybe try to use the same versions of the tools (OS, python, jupyter,etc). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154
Also, closes all charts after being used in order to not retain in memory, avoiding the warning message
RuntimeWarning: More than 20 figures have been opened. Figures created through the pyplot interface (matplotlib.pyplot.figure) are retained until explicitly closed and may consume too much memory. (To control this warning, see the rcParam figure.max_open_warning).