Conversation
…module @exadel/esl-website-e2e created
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
ala-n
requested review from
a team,
dshovchko,
fshovchko and
yadamskaya
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR introduces a new end-to-end testing module @exadel/esl-website-e2e that replaces the previous e2e test implementation with Playwright. The new module includes visual regression tests, content validation tests, and a GitHub Actions workflow for automated testing.
Changes:
- Created new Playwright-based e2e testing package with TypeScript configuration
- Implemented visual and content tests for the website homepage
- Updated GitHub Actions workflow to support Playwright tests with automatic snapshot updates
Reviewed changes
Copilot reviewed 11 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/esl-website-e2e/tsconfig.json | TypeScript configuration for the e2e test module |
| packages/esl-website-e2e/package.json | Package definition with Playwright dependencies |
| packages/esl-website-e2e/playwright.config.ts | Playwright configuration with device and environment settings |
| packages/esl-website-e2e/project.json | NX project configuration for running tests |
| packages/esl-website-e2e/common/page.ts | Utility functions for page interactions |
| packages/esl-website-e2e/tests/homepage.nav.visual.spec.ts | Visual tests for homepage navigation elements |
| packages/esl-website-e2e/tests/homepage.full.visual.spec.ts | Full-page visual regression test |
| packages/esl-website-e2e/tests/homepage.footer-content.spec.ts | Content validation tests for footer |
| packages/esl-website-e2e/.gitignore | Git ignore configuration for test artifacts |
| package.json | Updated e2e test commands to use new module |
| .github/workflows/e2e.yml | Refactored workflow for Playwright with improved triggers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: Update Playwright Snapshots | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.event_name == 'workflow_dispatch' && inputs.updateSnapshots }} | ||
| needs: [e2e-tests] |
There was a problem hiding this comment.
The 'update-snapshots' job depends on 'e2e-tests' but will only run when 'needs.e2e-tests.result == failure'' or on manual dispatch. However, if e2e-tests is skipped (when updateSnapshots is true on manual dispatch), the dependency will cause update-snapshots to be skipped as well. The needs dependency should be removed or made conditional.
dshovchko
left a comment
dshovchko
left a comment
There was a problem hiding this comment.
We need to document that system dependencies must be installed before starting work. This operation requires root or sudo privileges.
This is performed with the command npx playwright install --with-deps.
No description provided.