Skip to content

#219: Notebook-Connector can add Conda-Packages to SLCs #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Aug 13, 2025
Merged

#219: Notebook-Connector can add Conda-Packages to SLCs #222

merged 24 commits into from
Aug 13, 2025

Conversation

tomuben
Copy link
Contributor

@tomuben tomuben commented Aug 4, 2025 •
edited
Loading

fixes #219

Using Gzip, will again make the CI integration tests esp. for GPUs very long:

  • CompressionStrategy.NONE: 34m 38s
  • CompressionStrategy.GZIP: + 6 minutes = ~ 41 min total

Splitting up GPU tests into different matrix runs does accelerate the integration tests much:

  • 32m 59s with parallel execution (seehttps://github.com/exasol/notebook-connector/actions/runs/16916485738/job/47931788606?pr=222)
  • ca 35m with sequential execution

@tomuben tomuben temporarily deployed to manual-approval August 4, 2025 18:01 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 4, 2025 18:07 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 5, 2025 10:24 — with GitHub Actions Inactive
@tomuben tomuben had a problem deploying to text-ai-prerelease August 5, 2025 11:16 — with GitHub Actions Failure
@tomuben tomuben temporarily deployed to manual-approval August 6, 2025 10:55 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 6, 2025 11:00 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 6, 2025 11:31 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 6, 2025 11:36 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 6, 2025 11:41 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 6, 2025 11:46 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 6, 2025 12:00 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 6, 2025 12:02 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 6, 2025 13:49 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 6, 2025 13:54 — with GitHub Actions Inactive
@tomuben tomuben force-pushed the feature/219_slct_manager_support_for_conda_packages branch from 80c4928 to fd15760 Compare August 6, 2025 15:09
@tomuben tomuben temporarily deployed to manual-approval August 6, 2025 15:09 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 6, 2025 15:26 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 6, 2025 15:59 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 6, 2025 16:00 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 6, 2025 17:40 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 6, 2025 17:42 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 7, 2025 10:49 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 7, 2025 10:53 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 7, 2025 12:07 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 7, 2025 12:25 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 7, 2025 15:24 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 7, 2025 15:29 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 12, 2025 21:26 — with GitHub Actions Inactive
@tomuben tomuben had a problem deploying to text-ai-prerelease August 12, 2025 21:26 — with GitHub Actions Failure
@tomuben tomuben temporarily deployed to manual-approval August 12, 2025 21:30 — with GitHub Actions Inactive
@tomuben tomuben had a problem deploying to text-ai-prerelease August 12, 2025 21:30 — with GitHub Actions Failure
@tomuben tomuben temporarily deployed to manual-approval August 12, 2025 21:33 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 12, 2025 21:33 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 12, 2025 21:39 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 12, 2025 21:39 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 12, 2025 21:41 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 12, 2025 21:41 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 13, 2025 09:26 — with GitHub Actions Inactive
tkilias
tkilias previously approved these changes Aug 13, 2025
View reviewed changes
@tomuben tomuben temporarily deployed to text-ai-prerelease August 13, 2025 10:03 — with GitHub Actions Inactive
ckunki
ckunki reviewed Aug 13, 2025
View reviewed changes
exasol/nb_connector/slc/script_language_container.py
slc_flavor = SlcFlavor(name)
if slc_flavor.exists(secrets):
raise SlcError(
"Secure Configuration Storage already contains a"
f" flavor for SLC name {name}."
)
slc_compression_strategy = SlcCompressionStrategy(slc_name=name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha - maybe we should add SlcSession again, containing flavor and compression strategy.

ckunki
ckunki previously approved these changes Aug 13, 2025
View reviewed changes
@tomuben tomuben dismissed stale reviews from ckunki and tkilias via 9ea29d3 August 13, 2025 13:23
@tomuben tomuben temporarily deployed to manual-approval August 13, 2025 13:23 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 13, 2025 13:24 — with GitHub Actions Inactive
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tomuben tomuben merged commit f3bd973 into main Aug 13, 2025
27 checks passed
@tomuben tomuben deleted the feature/219_slct_manager_support_for_conda_packages branch August 13, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckunki ckunki ckunki approved these changes

@tkilias tkilias tkilias left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notebook-Connector can add Conda-Packages to SLCs
3 participants
@tomuben @tkilias @ckunki