fix Y direction misalignment of notes with offset H#831
Open
sr8e wants to merge 1 commit intoexch-bms2:masterfrom
Open
fix Y direction misalignment of notes with offset H#831sr8e wants to merge 1 commit intoexch-bms2:masterfrom
sr8e wants to merge 1 commit intoexch-bms2:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ノーツのoffset Hが設定されているとき、ノーツがその中心を基準に拡大縮小される(Y座標が
-offsetH / 2だけずらされる)ので、小節線と揃わなくなっているが、特にノーツの中心を基準にする必要がないように思われるので、ノーツの下端を基準とするように戻したい。Previously, notes are scaled around its center when offset H is set (i.e., Y value is offset by
-offsetH / 2, cf. 3f18134 ), causing misalignment with measure line (cf. #788)There would be no reason to do that, this simply removes the offset to resolve the issue.