Remove directive metadata copied to children #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires passing any relevant meta info onto the child node in run instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer blindly copy all directive metadata to
child.meta. However, this means we need to explicitly set any relevant attributes on the child from the directive duringrun(or the only way they will be accessible downstream is by traversing back up the tree to the child's parent).There is something to be said for blindly copying meta - that way
markdown-it-docutilsdoesn't need to decide what is important, it just passes along everything. But it's also nice to be a bit more explicit about what is available on the child.