binary-search: Update tests

[tasxatzial]

• Changed to return -1 instead of some kind of error when value is not in the vector
• Updated function template

[github-actions]

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

[tasxatzial]

I'm trying to change the description, but i'm not having any success. I'm trying

(defn update-test-case [test-case]
  (assoc test-case :description "new description"))

[tasxatzial]

@ErikSchierboom Any idea why updating the description isn't working? Should the above code work, or am I missing something?

[ErikSchierboom]

@tasxatzial That's because the description is overwritten later in the call chain:

(defn- test-case->data [idx node]
  (-> node
      (assoc :idx (inc idx)
             :description (str/join " ▶ " (:path node))
             :error (get-in node [:expected :error]))
      (dissoc :reimplements :comments :scenarios)))

That might not be the best design. Would you like me to have this happen before the update-test-case function is called?

[tasxatzial]

I was just looking at that particular piece of code.

Would you like me to have this happen before the update-test-case function is called?

Yes, please :)

[ErikSchierboom]

It'll be next week before I have time