binary-search: use equal for all numeric test comparisons #319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a question about consistency within a test suite and across all the exercises than anything else. I'll also preface this with noting that I rarely write elisp. If there are rules or best practices for what follows regarding equality other than the docstrings, I don't know about them.
If a beginner looks at the tests, they might be confused that some use
=
and others useequal
for comparison. They may then decide to discover that there's=/eq/eql/equal/char-equal/...
and so on. Aside from that, if I write a function that I know will only ever return integers, I'll use=
. If it could also return nil, I'd blanket useequal
(or possibly eveneql
instead.Are the other exercises in the track consistent with comparisons?