Skip to content

Add @DisplayName to Test Methods in Practice Exercises #2971 #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EmmanuelBerkowicz
Copy link

Add @DisplayName annotations to swift-scheduling tests

Replace existing @DisplayName annotations with canonical descriptions from problem-specifications to ensure consistency across tracks.

pull request

Summary

Replace existing @DisplayName annotations in swift-scheduling tests with canonical descriptions from problem-specifications to ensure consistency across tracks.

Changes Made

  • Updated all 16 test methods with canonical descriptions from canonical-data.json
  • Maintained existing test logic and functionality
  • Only modified @DisplayName annotations for better test output readability

Example

Before:

@DisplayName("NOW at 9 AM")

After:
@DisplayName("NOW translates to two hours later")


Reviewer Resources:

Track Policies

Add @DisplayName annotations to swift-scheduling tests

Replace existing @DisplayName annotations with canonical descriptions
from problem-specifications to ensure consistency across tracks.
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@@ -128,7 +128,7 @@ void testEowDuringLeapYear() {

@Disabled("Remove to run test")
@Test
@DisplayName("2M in January")
@DisplayName("2M before the second month of this year translates to the first workday of the second month of this year")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@DisplayName("2M before the second month of this year translates to the first workday of the second month of this year")
@DisplayName(
"2M before the second month of this year translates to the first workday of the second month of this year"
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was causing the Checkstyle error.
You can refer to CONTRIBUTING.md for guidance on how to run Checkstyle locally before creating a PR.

@jagdish-15 jagdish-15 added the x:rep/small Small amount of reputation label Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/small Small amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants