Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to fetch configlet to PR template #268

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

muzimuzhi
Copy link
Contributor

@muzimuzhi muzimuzhi commented Aug 18, 2024

Summary

Program configlet mentioned in the Checklist of PR template is not contained in this repo. This PR adds the step to fetch the latest configlet.

I noticed this repo also contains a fetch-configlet.ps1 for Windows PowerShell users. Is it recommended to also add a variant for Windows users?

TODO: Sync the change to https://github.com/exercism/common-lisp, from where the .github/pull_request_template.md is copied. See #106.

Checklist

  • If docs where changed, run ./bin/configlet generate to ensure all documents are properly generated.
  • CI is green

@glennj glennj added the x:rep/tiny Tiny amount of reputation label Aug 18, 2024
@glennj glennj merged commit cdadfa1 into exercism:main Aug 18, 2024
2 checks passed
@glennj
Copy link
Contributor

glennj commented Aug 18, 2024

The fetch* scripts are managed centrally and pushed out to all track repos.

I think windows users can probably figure it out. If not, they'll let us know.

@muzimuzhi
Copy link
Contributor Author

The fetch* scripts are managed centrally and pushed out to all track repos.

True for fetch* scripts (found it in https://github.com/exercism/org-wide-files/tree/main/tracks-files/bin), but I meant to refer to the PR template, which is not managed centrally and is only contained in a few tracks (currently only 4), with different contents.
https://github.com/search?q=org%3Aexercism+path%3A%22.github%2Fpull_request_template.md%22&type=code

Do you suggest adding a similar ./bin/fetch-configlet to the PR template in common-lisp track?

@muzimuzhi muzimuzhi deleted the pr-fetch-configlet branch August 18, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/tiny Tiny amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants