Implementing "say" exercise for R track#394
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
The notoriously tough R linter picked up a few details. No problems, this should be an easy fix. |
changed `small.n` to `small_n` and added spaces aound `=` to fix linter warnings.
Added `# nolint` to a long line
|
These are the warnings the linter gave: To placate it, I changed I should stress that none of these is a syntax error, just a conflict with the style guide chosen for this track. |
|
I've approved this, but I've left you to have the satisfaction of pressing the "Squash and merge" button (twice - it will ask you to confirm). One other file that is probably worth adding at some point is |
|
I don't think I've seen hints on the R track. Can you link to an example? I don't know how to execute this "squash and merge" The linter prefers |
On this website page, are you not seeing 3 green ticks and a big green button? You just click the button, then a second button asking for confirmation. If there's a problem, I'll do it, but I thought the creator of the PR had authorization to do this once the PR is approved.
Maybe you found a problem, and this track has few hints (BAD, and something that needs fixing). I'll look into it more tomorrow, and if necessary I'll open an issue. Also: linters are strange, and can be annoying. Sorry, this wasn't something I chose. I could make a case for relaxing the rules within Exercism, but I'm not sure whether I would get agreement. |
|
The three green tick marks yes, the green button, no...screenshot of this page as it appears in my browser |
|
@colinleach likely only those with write access can merge ;) |
|
Apologies, my mistake. I've now merged it, so you should (1) see the exercise appear on the Exercism website; (2) see a bunch of rep appear on your account. |
Alarmingly, no I can't! I've opened Issue #398 to discuss this. |

Followed recipe at https://exercism.org/docs/building/tracks/practice-exercises with a little help from my friends IsaacG and colinleach in the Exercism Community.