Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercises/practice/anagram: add an append with instructions about the order of the return values #328

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

IsaacG
Copy link
Member

@IsaacG IsaacG commented Jan 15, 2025

No description provided.

@IsaacG
Copy link
Member Author

IsaacG commented Jan 16, 2025

Clarify what this track expects. Context: https://forum.exercism.org/t/14816/

@IsaacG
Copy link
Member Author

IsaacG commented Jan 18, 2025

+cc @exercism/cross-track-maintainers

@BNAndras
Copy link
Member

Is there a particular reason we need the rest of the append? That seems like content better covered elsewhere in the track docs.

@IsaacG
Copy link
Member Author

IsaacG commented Jan 18, 2025

Is there a particular reason we need the rest of the append? That seems like content better covered elsewhere in the track docs.

No clue :) I just tidied up the formatting slightly. I can revert the changes to the other lines if you prefer.

@glennj
Copy link

glennj commented Jan 18, 2025

There appear to be no scheme maintainers (https://github.com/orgs/exercism/teams/scheme) so let's just clean it up. It does echo the https://exercism.org/docs/tracks/scheme/tests page.

@BNAndras
Copy link
Member

https://github.com/search?q=repo%3Aexercism%2Fscheme+%22Running+and+testing+your+solutions%22&type=code shows that this is a common append. The Scheme track generates their test-specific documentation programatically like https://github.com/exercism/scheme/blob/566dfd3696fd94d4066d610d4a8d8928983d7048/input/docs/TESTS.ss but I think the appends are by hand. So we could edit those without an issue.

I suspect the append is primarily for folks working offline, but they can refer to the track-specific docs about testing instead. I think it'll be simpler to address these appends in a later PR and just merge this PR for now.

@glennj
Copy link

glennj commented Jan 18, 2025

Offline people get the test instructions in HELP.md. The "how to test" text gets added into it.

@IsaacG
Copy link
Member Author

IsaacG commented Jan 19, 2025

Happy to drop that append stuff ... but maybe that should be a separate (follow up) PR? This batch of PRs is specific to discussing the order of the elements.

@BNAndras
Copy link
Member

That’s what i’m thinking as well. I’ll merge this in though.

@BNAndras BNAndras merged commit 5574c6d into exercism:main Jan 19, 2025
4 checks passed
@IsaacG IsaacG deleted the anagram.append.return_order branch January 19, 2025 05:02
@IsaacG
Copy link
Member Author

IsaacG commented Jan 19, 2025

Please see #329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants