-
-
Notifications
You must be signed in to change notification settings - Fork 14
Add basic SELECT concept #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
+cc @exercism/sqlite |
|
Quick thoughts before a more thorough review.
|
|
Hey blackk-foxx, The main challenge for the syllabus is to find fitting exercises that go with the concepts. I am excited to see a fitting and engaging one. There is a pool of exercises, but they may not be suitable for that use case. Also, apart from the one sentence per line, Isaac's link has some more formatting rules that are useful to implement. The link style, for example. |
|
Thanks for the initial review @IsaacG. I have addressed points 1, 2, and 3.
In my original draft, I was using "query" to mean retrieval. But I now gather that a query can really represent any operation that can be expressed in SQL (read, create, update, delete). If we all agree to use "query" in the more general sense, then I would expect it to be defined in a higher-level introduction outside of this document. Any thoughts on this?
I'd be glad to create one, but I would really welcome any advice on adapting the test framework. The existing test framework is designed to handle scalar values, but for a basic |
caf179e to
97970db
Compare
@vaeng, thanks for pointing that out. I have converted the link to a reference link and the note to an |
|
quick question: any differences between about.md and introduction.md? |
|
This is well written. Frankly I was left wanting more :) but I think that's the sign of a properly-sized concept doc. I think DISTINCT can be put into a concept with GROUP BY. Unless the planned concept exercises will practice it. I eagerly await reading about expressions, ORDER BY, GROUP BY, subselects, NULL and so on |
No differences. @IsaacG advised that they are typically identical. |
- Replace "dataset" with "result set" - Remove DISTINCT
Removed DISTINCT. |
OTOH, I have noticed in concepts on other tracks that introduction.md contains a high-level summary of the concept while about.md contains the full document. Any reason not to use that same model here? |
If you want to add additional content, I think it probably makes sense for that content to be added as an addendum/append with the first half of the doc remaining the same. I believe a template file can be used to avoid duplicating content. |
JavaScript does this sometimes on purpose. A lot of content for concepts is really not important to understand but we do want to provide. I do not agree with any of the Cons (whilst they are true) Isaac listed to be a reason to not do that. The UI should be improved to remove one of the two cons and I don't think the maintenance burden is actually a burden, but YMMV. The important "Pro" that's missed is that you can include information that should not be taught in the exercise, but is interesting to consume when students go and explore. That said: in general they are often similar and almost always Tip: you can link to (previous) concepts using a special syntax |
No description provided.