Update tests for pangram, roman-numerals, and triangle #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BNAndras
added
x:action/sync
11 tasks
kotp
approved these changes
Dec 28, 2023
| unlet! input expected | ||
|
|
||
| Execute (sentence empty): | ||
| Execute (empty sentence): |
There was a problem hiding this comment.
Unless this is coming from upstream, perhaps this should be phrase, since not all pangrams are sentences. (As evidenced by this empty "sentence". While it is probably accurate to describe this as an empty string.
There was a problem hiding this comment.
I agree, but that's the description upstream unfortunately. However, we have some leeway here as long as it's clear that "empty string" here is the "empty sentence" from the tests.toml. I think it's safe to make that tweak.
|
Related to #248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First batch of test syncs