Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update V compiler #39

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

keiravillekode
Copy link
Contributor

@keiravillekode keiravillekode commented Dec 3, 2023

We update to V version weekly.2023.48 weekly.2024.22

@ErikSchierboom
Copy link
Member

Could you fix CI? I think some expected tests need to be updated,

@keiravillekode
Copy link
Contributor Author

keiravillekode commented Dec 5, 2023

I have no idea what happened with those CI errors.

Regardless, let's wait a week for weekly.2023.49 weekly.2023.50

exercism/vlang#176

@ErikSchierboom
Copy link
Member

I have no idea what happened with those CI errors.

Well that's likely because the output of the newer compiler is slightly different from the old one. You'd just need to update the expected files in the test cases.

@hraftery
Copy link
Contributor

hraftery commented Dec 5, 2023

I have no idea what happened with those CI errors.

Well that's likely because the output of the newer compiler is slightly different from the old one. You'd just need to update the expected files in the test cases.

You can see an example of what needs to be updated in this PR - it's the expected_results.json files, because the format of the results changes from time to time. In this case, it looks like it's the one in example-syntax-error folder. Just confirm the differences are formatting only, and replace the expected_results.json file with the actual results.json file.

We update to V version weekly.2023.48
@keiravillekode
Copy link
Contributor Author

I have fixed the issues. Now using weekly.2024.22

@1ethanhansen 1ethanhansen merged commit 275aef8 into exercism:main Jul 1, 2024
1 check passed
@keiravillekode keiravillekode deleted the use-weekly-2023-48 branch July 1, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants