Add support for stanza 1.7 and 1.8#102
Open
michael-k wants to merge 1 commit intoexplosion:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are green with #101. They fail because emoji 2.12.0 (a dependency of stanza) doesn't have a lower bound on typing-extensions (see carpedm20/emoji#297), but spacy has an upper bound ( 😢 ).
There are other ways to fix this¹ apart from dropping support for Python < 3.8, but with 3.7 being beyond its lifespan for almost 1 year and your work on spacy 4 (although I don't know when to expect this), I don't think its worth it.
Also: That the tests for Python 3.7 fail is unrelated to this PR. They fail for the default branch as well.
¹Eg. relax the upper bound in spacy or disallow emoji 2.12.0 to be installed