try_read_slice and try_write_slice#257
Merged
xv-pete-m merged 1 commit intoexpressvpn:mainfrom Aug 16, 2025
Merged
Conversation
Contributor
kp-mariappan-ramasamy
left a comment
kp-mariappan-ramasamy
left a comment
There was a problem hiding this comment.
LGTM
Minor comment about safety comments.
Also we allow only signed commits to the repo. Can you please sign the commit and push ?
markasoftware
force-pushed
the
markasoftware/read-write-slices
branch
2 times, most recently
from
2dd2964 to
328d7df
Compare
Contributor
Author
|
I've fixed the comment and signed the commit. Thanks! |
kp-mariappan-ramasamy
previously approved these changes
Aug 14, 2025
kp-mariappan-ramasamy
force-pushed
the
markasoftware/read-write-slices
branch
2 times, most recently
from
328d7df to
7ddcc79
Compare
kp-mariappan-ramasamy
force-pushed
the
markasoftware/read-write-slices
branch
from
7ddcc79 to
a207ea4
Compare
kp-mariappan-ramasamy
approved these changes
Aug 15, 2025
Contributor
|
LGTM, thanks for the contribution |
Contributor
Author
|
Thanks for the review @kp-mariappan-ramasamy , but I'm unable to merge this:
|
xv-pete-m
approved these changes
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for those of us not using
BytesMutin our own applications. SinceBytesMutis always on the heap this is good when you want to avoid heap allocations.I should probably add a test for
try_read_sliceat least since it's not called fromtry_read...Resolves #256