Fix: koulen font with incorrect path #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardovillao
changed the title
eduardovillao
added
bug
KevinBatdorf
requested review from
amjadr360
and removed request for
KevinBatdorf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
Closes #1317
Problem
Recently, we changed all font file names to lowercase. However, there is still a request being made for:
/wp-content/themes/extendable/assets/fonts/koulen/Koulen-Regular.woff2when the correct path should be:/wp-content/themes/extendable/assets/fonts/koulen/koulen-regular.woff2.This mismatch causes a 404 error when the font is requested.
Solution
The fix was to rename the font file reference to lowercase in theme.json, ensuring it matches the updated file name.
How to Test
Blockages for Merge (if any)
None.