Skip to content

Conversation

panic-kbutton
Copy link

allow local config to override github graphql requests like so

[ghstack]
github_url = github.com
github_oauth = garbage
github_username = panic-kbutton

[repo]
name = myrepo
owner = myorg
id = 111111111
default_branch = main
is_fork = false

# Name of the upstream remote
("remote_name", str),
# Repository name
("repo_name", Optional[str]),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, while I want to accept this PR on principle, this is not so good, it means you can only set one repo name for all ghstack uses everwhere on your machine. Any chance I can convince you to introduce a per repo configuration? :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense - will give that a stab!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking that with use of github_path in the ~/.ghstack config, I can add a check where, if $github_path/.ghstack exists, use that for per-repo config, otherwise assume no per-repo config exists. is that what you were thinking?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some precedent for just chucking stuff in .git/config (using the standard git cli for modifying it.) How do you like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants