fix: Normalize param's names of "safe" object #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normalize param's names for "safe" object
miketsoft
changed the title
miketsoft
commented
Oct 3, 2025
| // add other cases to support other param name/value pairs | ||
| default: | ||
| $attr['name'] = $attr['value'] = null; | ||
| $attr['name'] = $attr['value'] = ''; |
There was a problem hiding this comment.
Using null values instead of strings is deprecated in functions like htmlspecialchars
| $new[] = new HTMLPurifier_Token_Empty('param', array('name' => $name, 'value' => $value)); | ||
| $paramStack[strtolower($name)] = true; | ||
| } | ||
| $this->paramStack[] = $paramStack; |
There was a problem hiding this comment.
From line 67: we've already added these parameters, so we must initialize the parameters stack with them to avoid duplicates later.
| // already been added | ||
| if (!isset($this->paramStack[$i][$n]) && | ||
| isset($this->addParam[$n]) && | ||
| $token->attr['name'] === $this->addParam[$n]) { |
There was a problem hiding this comment.
It appears that there is a bug: the condition $token->attr['name'] === $this->addParam[$n] always evaluates to false. This has been corrected to use $token->attr['value'] instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#459