chore(02): step 2 - algorithmics#3
Open
fabernovel-fnguyen wants to merge 2 commits into01_correctionfrom
Open
Conversation
| }; | ||
| } | ||
|
|
||
| private extractStatFromResponse( |
There was a problem hiding this comment.
Might have: On pourrait renommer en extractBaseStatFromResponse et retourner un number à la place de PokeAPIStats.
Puisqu'on utilise cette fonction que pour récupérer le base_stat. Donc au lieu de return match; se serait return match.base_stat;
Sauf si tu voulais l'utiliser pour récupérer d'autre champ ? 🤔
fabernovel-fnguyen
force-pushed
the
02_algorithmics
branch
from
cec1faa to
961ffb9
Compare
fabernovel-fnguyen
force-pushed
the
01_correction
branch
from
cf069b7 to
82e24cb
Compare
michaelantounfabernovel
force-pushed
the
01_correction
branch
from
82e24cb to
df6c095
Compare
michaelantounfabernovel
force-pushed
the
02_algorithmics
branch
2 times, most recently
from
bd2e04c to
3475f96
Compare
michaelantounfabernovel
force-pushed
the
01_correction
branch
from
af40983 to
5633ffe
Compare
michaelantounfabernovel
force-pushed
the
02_algorithmics
branch
from
3475f96 to
3593cf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.