Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add TDD non-reg illustrating #213 problem (currently still failing) #216

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add TDD non-reg illustrating #213 problem (currently still failing) #216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd963c5
test: allow additional parameters to test_app()
vorburger Jan 16, 2019
72b93c5
test: add TDD non-reg illustrating #213 problem (failing)
vorburger Jan 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ set -ex
function test_app() {
local name=$1
local port="8080"
local extra_args=${2:-""}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just leave out "" (that's the default anyway)


local container_id=$(docker run --name ${name}-test -d -p ${port} ${name})
local container_id=$(docker run --name ${name}-test -d -p ${port} ${extra_args} ${name})

# sleep is required because after docker run returns, the container is up but our server may not quite be yet
sleep 5
Expand Down Expand Up @@ -85,6 +86,7 @@ function test_entrypoint() {

function test_container() {
test_app $1
test_app $1 "-e JAVA_DIAGNOSTICS=TRUE" # https://github.com/fabric8io-images/s2i/issues/213
test_metrics $1
}

Expand Down