common: patch: i3c: Handle missing slave callbacks gracefully #2488
+61
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# [Issue Description] - System crashes with assertion failure when I3C slave receives data but no userspace application callback is registered - The __ASSERT(0, "flush rx fifo is TBD") causes system halt # [Root Cause] - When master writes data to I3C slave device, the driver expects a callback function to handle the received data - If no callback is registered, the driver hits an assertion and crashes instead of gracefully handling the situation - RX FIFO data remains unread, potentially causing hardware buffer overflow # [Solution] - Replace __ASSERT with LOG_WRN to provide non-fatal warning message - Implement RX FIFO flushing mechanism when no callback is available - Add null pointer checks in i3c_aspeed_rd_rx_fifo() to safely handle flush operations - Ensure hardware RX FIFO is properly cleared to prevent buffer overflow
meta-cla
bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D79976748. (Because this pull request was imported automatically, there will not be any future comments.) |
|
This pull request has been merged in 05e3c0d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Issue Description]
[Root Cause]
[Solution]