Support OSS folly build #16
Open
+24,687
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cxx_bridge is specified, generate a genrule that runs cxxbridge to create the C++ header file, available as name@header subtarget. The @Header target is a cxx_library that exports the generated header so dependent C++ code can include it.
(antlir github revision 6448ac9b12c0a85386f3d00d605339760654d8e6)
libiberty will be built by Conan with gcc (C library, no ABI issues). Use pkgconfig to pick up the library path from Conan's pkg-config files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the necessary updates/shims for the OSS buck2 folly build to work.
Evidence is in folly #2542 which provides the pins necessary to provide a clean build of folly #2541.