rust-project: populate sysroot_src
#1187
Open
+43
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D89837619. (Because this pull request was imported automatically, there will not be any future comments.) |
According to https://rust-analyzer.github.io/book/non_cargo_based_projects.html, rust-analyzer should compute `sysroot_src` from `sysroot` if it is absent. According to my testing, this is not the case, and rust-analyzer is broken if `sysroot_src` is not populated. To fix this, we populate it from a new `--sysroot-src` flag, or the de facto standard `RUST_SRC_PATH`, which fixes the issue. Ideally, rust-analyzer should be fixed but: 1. I haven't gotten to the bottom of that bug. 2. This commit remains correct in the meantime. 3. This commit allows setups where the binary sysroot and source sysroots are different (as is the case in Nixpks, where they come from different packages).
cbarrete
changed the title
sysroot_src from RUST_SRC_PATHsysroot_src
Contributor
|
This is covered by #767 in a bit more of a comprehensive way. (767 auto populates sysroot_src from sysroot, and also checks that that sysroot_src path exists, i.e. whether you have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
https://rust-analyzer.github.io/book/non_cargo_based_projects.html, rust-analyzer should compute
sysroot_srcfromsysrootif it is absent.According to my testing, this is not the case, and rust-analyzer is broken if
sysroot_srcis not populated.To fix this, we populate it from a new
--sysroot-srcflag, or the de facto standardRUST_SRC_PATH, which fixes the issue.Ideally, rust-analyzer should be fixed but: