Don't kill a daemon pid that is not a buck2 process - #1425
Open
bvinc wants to merge 1 commit into
Open
Conversation
buckd.info records a bare pid. If that daemon died without cleaning up, the OS may have reused the pid, so hard_kill_impl could terminate an unrelated process - including an ancestor of the client, which kills the client itself. Check identity before killing, using the same rules killall already applies: a buck2 executable, and not an ancestor of this process. Unknown identity still kills, so callers that report the kill to the user keep today's behavior.
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D114131032. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buckd.info records a bare pid. If that daemon died without cleaning up, the OS may have reused the pid, so hard_kill_impl could terminate an unrelated process
Check identity before killing, using the same rules killall already applies: a buck2 executable, and not an ancestor of this process. Unknown identity still kills, so callers that report the kill to the user keep today's behavior.