Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Bad Resource Link in Documentation - Issue #13649 #13650

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chandankumarm55
Copy link

This PR fixes the bad resource link mentioned in issue #13649. The issue was that the app was making a request to the URL camo.githubusercontent.com, which resulted in a 404 page not found error. I downloaded the original image and added it locally to avoid any external requests, ensuring the image will load permanently. The link has been updated accordingly.

Issue #13649 is now resolved.

Before:

359107015-8b49073d-72db-4634-9744-bf3a160e2ba8

After:

Screenshot (179)

Happy contributing!

@facebook-github-bot
Copy link

Hi @chandankumarm55!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@chandankumarm55
Copy link
Author

Hey Please Merge my PR in to main branch

@iglesias
Copy link

Hey

I encountered the original issue too (Chromium on Arch)

After a quick check, I believe the cause is a bit different

curl -I https://camo.githubusercontent.com/29765c4a32f03bd01d44edef1cd674225e3c906b/68747470733a2f2f63646e2e7261776769742e636f6d2f66616365626f6f6b2f6372656174652d72656163742d6170702f323762343261632f73637265656e636
173742e737667

HTTP/2 403
cache-control: no-cache, no-store, private, must-revalidate
content-security-policy: default-src 'none'; img-src data:; style-src 'unsafe-inline'
content-type: text/plain; charset=utf-8
strict-transport-security: max-age=31536000; includeSubDomains
x-content-type-options: nosniff
x-frame-options: deny
x-xss-protection: 1; mode=block
server: github.com
x-github-request-id: 61BC:AB576:537DFC:62D180:66E676FF
accept-ranges: bytes
date: Sun, 15 Sep 2024 05:56:26 GMT
via: 1.1 varnish
x-served-by: cache-tyo11926-TYO
x-cache: MISS
x-cache-hits: 0
x-timer: S1726379786.049627,VS0,VE179
x-fastly-request-id: 034ade0fa6bad667d71a5655cf046dde28e6cd42
timing-allow-origin: https://github.com
content-length: 14

and the original resource an animation instead of a static png

echo "68747470733a2f2f63646e2e7261776769742e636f6d2f66616365626f6f6b2f6372656174652d72656163742d6170702f323762343261632f73637265656e636173742e737667" | xxd -r -p

https://cdn.rawgit.com/facebook/create-react-app/27b42ac/screencast.svg

@chandankumarm55
Copy link
Author

@iglesias "Oh, it should be an animation instead of a static picture? The image should use the URL: https://cdn.rawgit.com/facebook/create-react-app/27b42ac/screencast.svg. Thanks for sharing the URL. I will apply this URL and create a pull request again."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants