-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Bad Resource Link in Documentation - Issue #13649 #13650
base: main
Are you sure you want to change the base?
Conversation
Hi @chandankumarm55! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Hey Please Merge my PR in to main branch |
Hey I encountered the original issue too (Chromium on Arch) After a quick check, I believe the cause is a bit different
and the original resource an animation instead of a static png
|
@iglesias "Oh, it should be an animation instead of a static picture? The image should use the URL: https://cdn.rawgit.com/facebook/create-react-app/27b42ac/screencast.svg. Thanks for sharing the URL. I will apply this URL and create a pull request again." |
This PR fixes the bad resource link mentioned in issue #13649. The issue was that the app was making a request to the URL
camo.githubusercontent.com
, which resulted in a 404 page not found error. I downloaded the original image and added it locally to avoid any external requests, ensuring the image will load permanently. The link has been updated accordingly.Issue #13649 is now resolved.
Before:
After:
Happy contributing!