refactor: replace unmaintained shelljs dependency by execa #10358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: -1.05 kB (-0.01%) Total Size: 11.5 MB ℹ️ View Unchanged
|
slorber
changed the title
slorber
added
the
Argos
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: -1.06 kB (-0.01%) Total Size: 11.1 MB ℹ️ View Unchanged
|
|
Size Change: -1.07 kB (-0.01%) Total Size: 11.6 MB ℹ️ View Unchanged
|
| } | ||
|
|
||
| // Clear out any existing contents in the target directory | ||
| shellExecLog(`git rm -rf ${targetDirectory}`); | ||
| exec(`git rm -rf ${escapeArg(targetDirectory)}`, { |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input Medium
slorber
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
LGTM 👍
This replaces the unmaintained shelljs dependency by execa (v5 because upper versions are ESM only)
Fix #10348
I tested locally everything keeps working, but it's error-prone and shelljs/execa behave differently in terms of arg escaping.
Note: this PR doesn't replace sync by async, but tries to keep the same behavior as before by switching lib.
More refactoring can be done in other PRs, but considering all this is not well-covered by tests, it's risky and we should rather write tests first.
slorber
changed the title
slorber
added
pr: maintenance
slorber
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Replace unmaintained shelljs dependency
Fix #10348 ?
Test Plan
Unit tests + preview
Test links
https://deploy-preview-10358--docusaurus-2.netlify.app/