Skip to content

G300 simulator enablement changes - #1590

Open
snisha-cisco wants to merge 5 commits into
facebook:mainfrom
snisha-cisco:revised-g300-simulater-enablement
Open

G300 simulator enablement changes#1590
snisha-cisco wants to merge 5 commits into
facebook:mainfrom
snisha-cisco:revised-g300-simulater-enablement

Conversation

@snisha-cisco

@snisha-cisco snisha-cisco commented Sep 3, 2026

Copy link
Copy Markdown

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

The following changes enable simulator for G300 to run FBOSS tests

SAI / ASIC behavior

ACL

  • MIRROR_EGRESS is programmed only on egress ACL tables for Tajo SDK >= 24.8.3001; ingress tables skip it.
  • Tajo extra qualifier DST_MAC is not advertised as supported (commented out).
  • getActionTypeList takes aclStage so action-type conversion is stage-aware.
  • ACL entry extended label is emitted only when SAI_ACL_ENTRY_ATTR_EXT_LABEL_EXTENDED is defined.

Router interfaces / MPLS

  • Port RIFs set AdminMplsState=true when HwAsic::Feature::MPLS is supported (previously VLAN RIFs only, hardcoded to Ebro/P200).
  • Yuba ASIC advertises the MPLS feature.

Serdes / PFC / buffers (Yuba + G202x)

  • Skip Tx FIR Post2 checks for Chenab and Yuba/G202x.
  • PFC watchdog min intervals (200/400 ms) apply to Yuba/G202x as well as Chenab.
  • Yuba MMU size updated.
  • PFC tests use a dedicated egress pool instead of sharing the ingress pool size.
  • Olympic WRR queues on G200/G202x attach a pool with reservedBytes so the SDK does not recompute reserve on every queue attach.

NSIM

  • SDK_DEVICE_NAME overrides /dev/uio0 for the P200/Yuba/G202x connection handle.

IP-in-IP

  • Expected IPv6 traffic class after decap: 0xF8 -> 0xFA (GR3 DSCP/TC mapping).

Test Plan

Necessary info has been provided to Meta.

@snisha-cisco
snisha-cisco requested a review from a team as a code owner September 3, 2026 07:39
@meta-cla meta-cla Bot added the CLA Signed label Sep 3, 2026
@snisha-cisco snisha-cisco changed the title Revised g300 simulater enablement changes Revised G300 simulater enablement changes Sep 3, 2026
@snisha-cisco snisha-cisco changed the title Revised G300 simulater enablement changes Revised G300 simulator enablement changes Sep 3, 2026
@snisha-cisco snisha-cisco changed the title Revised G300 simulator enablement changes G300 simulator enablement changes Sep 3, 2026

@Santosh-KSingh Santosh-KSingh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants