[Nexthop] Fix SIGABRT in h/w agent on unsupported packet RX reason - #1617
Open
vvasavada-nexthop wants to merge 1 commit into
Open
[Nexthop] Fix SIGABRT in h/w agent on unsupported packet RX reason#1617vvasavada-nexthop wants to merge 1 commit into
vvasavada-nexthop wants to merge 1 commit into
Conversation
Signed-off-by: Vishrant Vasavada <vvasavada@nexthop.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
SaiHostifManager::packetReasonToHostifTrap()threw anFbossErrorfor any packet RX reason it could not map to a SAI hostif trap on the current ASIC/SDK build (e.g.L3_SLOW_PATH,MPLS_UNKNOWN_LABEL). When such a reason arrives in control plane delta, the exception escapes the oper-delta thread inSaiSwitch::stateChangedImplLocked, aborting the h/w agent withSIGABRT.The software agent's config validation layer (
isValidRxReasonToQueue) cannot fully gate these reasons, because some are gated by compile-time SAI SDK macros (SAI_API_VERSION,BRCM_SAI_SDK_DNX_GTE_11_0, etc.) that are visible only in the SAI layer, not in the platform-agnostic agent code.Fix
Make the SAI hostif trap mapping non-fatal, matching the established skip-with-diagnostic pattern already used throughout the SAI managers (and already used for
UNMATCHEDin this same function):packetReasonToHostifTrap()andmakeHostifTrapAttributes()now returnstd::optional.XLOG(ERR)and returnsstd::nulloptinstead of throwing.Test Plan
Before the fix:
HostifManagerTest.unsupportedHostifTrapSkippedfailsAfter the fix:
HostifManagerTest.unsupportedHostifTrapSkippedpasses.