-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][lexical[lexical-utils] Feature: NodeCaret abstraction for traversals and ranges #7046
Draft
etrepum
wants to merge
18
commits into
facebook:main
Choose a base branch
from
etrepum:lexical-caret
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 13, 2025
size-limit report 📦
|
etrepum
changed the title
[WIP][lexical[lexical-utils] Feature: NodeCaret abstraction for traversals and ranges
[WIP][Breaking Change][lexical[lexical-utils] Feature: NodeCaret abstraction for traversals and ranges
Jan 14, 2025
etrepum
changed the title
[WIP][Breaking Change][lexical[lexical-utils] Feature: NodeCaret abstraction for traversals and ranges
[WIP][lexical[lexical-utils] Feature: NodeCaret abstraction for traversals and ranges
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: This is a work in progress, not a finalized proposal
A fair amount of bugs and complexity in our code results from ambiguity and awkwardness around traversing the node tree, as well as issues around coordinates becoming stale after mutations. This is a draft in-progress proposal for a new set of abstractions that can be used in place of the typical
PointType
andRangeSelection
to work through these sorts of traversal use cases with hopefully fewer bugs.There are two major deficiencies that the design of
NodeCaret
hopes to address:At this time there's no special support for
TextNode
. ANodeCaret
is a triple of: