Fix snappy RTTI linker error in open-source CI#166
Closed
shitanshu-shah wants to merge 1 commit into
Closed
Conversation
Summary:
Snappy >= 1.1.9 disables RTTI by default via `set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-rtti")` in its CMakeLists.txt (google/snappy#184). This causes `undefined reference to typeinfo for snappy::Source` when linking openr binaries, because folly's compression module (compiled with RTTI) references snappy's typeinfo which the RTTI-stripped `libsnappy.so` doesn't export.
The previous approach of passing `CMAKE_CXX_FLAGS=-frtti` via `--extra-cmake-defines` does not work because snappy's CMakeLists.txt explicitly strips any existing `-frtti` before appending `-fno-rtti`.
Fix: add a workflow step after fetching snappy that patches its CMakeLists.txt to remove `-fno-rtti`, restoring the GCC default (RTTI enabled). This is the same approach used by Fedora, Debian, and openSUSE to work around google/snappy#184.
Reviewed By: mloo3
Differential Revision: D107163112
Contributor
|
@shitanshu-shah has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107163112. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Snappy >= 1.1.9 disables RTTI by default via
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-rtti")in its CMakeLists.txt (google/snappy#184). This causesundefined reference to typeinfo for snappy::Sourcewhen linking openr binaries, because folly's compression module (compiled with RTTI) references snappy's typeinfo which the RTTI-strippedlibsnappy.sodoesn't export.The previous approach of passing
CMAKE_CXX_FLAGS=-frttivia--extra-cmake-definesdoes not work because snappy's CMakeLists.txt explicitly strips any existing-frttibefore appending-fno-rtti.Fix: add a workflow step after fetching snappy that patches its CMakeLists.txt to remove
-fno-rtti, restoring the GCC default (RTTI enabled). This is the same approach used by Fedora, Debian, and openSUSE to work around google/snappy#184.Reviewed By: mloo3
Differential Revision: D107163112