fix: assert callable narrows too much #1946
Closed
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangdanny97
requested changes
Dec 29, 2025
Contributor
yangdanny97
left a comment
yangdanny97
left a comment
There was a problem hiding this comment.
We can't fix this by changing the bundled typeshed stubs, the source of truth is in https://github.com/python/typeshed so they'll get overwritten the next time we pull them
We can either:
- Make a PR to the typeshed repo
- Special-case
builtins.callable(...)narrowing behavior just like we do for issubclass, isinstance, etc.
Contributor
Author
|
@yangdanny97 I haven't think that way. Let me take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix assert callable(x) narrowing because callability does not imply an object return type
Fixes #911
Test Plan