fix: Mark completions as incomplete when local completions block autoimport #1979
+102
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When local completions exist (e.g.,
UsersController), autoimport completions are skipped for performance. However, the response was marked asis_incomplete=false, causing clients (Zed, nvim) to cache results and filter locally instead of requesting new completions from the server.This meant when typing
UsersM, the client would filter cached results and never showUsersManagerfrom autoimport.Now we mark
is_incomplete=truewhen local completions exist, so clients request completions again as the user types more characters, allowing autoimport completions to appear when local ones no longer match.Fixes #1398
Test Plan
test_completion_incomplete_with_local_completions_blocking_autoimporttest_completion_autoimport_shown_when_local_no_longer_matchestest.py- all tests pass including conformance tests