fix: Inferred return type of Never when a method body contains a for loop #1997
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
stroxler
requested changes
Jan 6, 2026
| "#, | ||
| ); | ||
|
|
||
| testcase!( |
Contributor
There was a problem hiding this comment.
I think maybe this PR doesn't have the code changes you intended?
This test case seems not relevant, and I also don't see an actual implementation of the loop logic (which may be why tests are failing).
Contributor
Author
There was a problem hiding this comment.
Let me check again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix implicit return inference so trailing for loops no longer cause functions without explicit return to be inferred as returning Never
Fixes #1491
Test Plan