Skip to content

feat(style): remove experimental_ prefix from backgroundImage #56668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
intergalacticspacehighway wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(style): remove experimental_ prefix from backgroundImage #56668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5f987c
feat(style): remove experimental_ prefix from backgroundImage
intergalacticspacehighway May 1, 2026
3f9e1ec
lint fix
intergalacticspacehighway May 1, 2026
311994e
regenerate API snapshot for backgroundImage
intergalacticspacehighway May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/Libraries/Components/View/ReactNativeStyleAttributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ const ReactNativeStyleAttributes: {[string]: AnyAttributeType, ...} = {
/**
* BackgroundImage
*/
experimental_backgroundImage: backgroundImageAttribute,
backgroundImage: backgroundImageAttribute,

/**
* BackgroundSize
Expand Down
5 changes: 2 additions & 3 deletions packages/react-native/Libraries/Components/View/__tests__/View-itest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,13 +335,12 @@ describe('<View>', () => {
<>
<View
style={{
experimental_backgroundImage:
'radial-gradient(#e66465, #9198e5)',
backgroundImage: 'radial-gradient(#e66465, #9198e5)',
}}
/>
<View
style={{
experimental_backgroundImage: [
backgroundImage: [
{
type: 'radial-gradient',
shape: 'ellipse',
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/Libraries/NativeComponent/BaseViewConfig.android.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ const validAttributesForNonEventProps = {
backgroundColor: colorAttribute,
transform: true,
transformOrigin: true,
experimental_backgroundImage: backgroundImageAttribute,
backgroundImage: backgroundImageAttribute,
experimental_backgroundSize: backgroundSizeAttribute,
experimental_backgroundPosition: backgroundPositionAttribute,
experimental_backgroundRepeat: backgroundRepeatAttribute,
Expand Down
5 changes: 1 addition & 4 deletions packages/react-native/Libraries/StyleSheet/StyleSheetTypes.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,10 +517,7 @@ export interface ViewStyle extends FlexStyle, ShadowStyleIOS, TransformsStyle {
filter?: ReadonlyArray<FilterFunction> | string | undefined;

mixBlendMode?: BlendMode | undefined;
experimental_backgroundImage?:
| ReadonlyArray<BackgroundImageValue>
| string
| undefined;
backgroundImage?: ReadonlyArray<BackgroundImageValue> | string | undefined;
experimental_backgroundSize?:
| ReadonlyArray<BackgroundSizeValue>
| string
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/Libraries/StyleSheet/StyleSheetTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,7 @@ export type ____ViewStyle_InternalBase = Readonly<{
boxShadow?: ReadonlyArray<BoxShadowValue> | string,
filter?: ReadonlyArray<FilterFunction> | string,
mixBlendMode?: ____BlendMode_Internal,
experimental_backgroundImage?: ReadonlyArray<BackgroundImageValue> | string,
backgroundImage?: ReadonlyArray<BackgroundImageValue> | string,
experimental_backgroundSize?: ReadonlyArray<BackgroundSizeValue> | string,
experimental_backgroundPosition?:
| ReadonlyArray<BackgroundPositionValue>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewProps.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public object ViewProps {
// Props that affect more than just layout
public const val ENABLED: String = "enabled"
public const val BACKGROUND_COLOR: String = "backgroundColor"
public const val BACKGROUND_IMAGE: String = "experimental_backgroundImage"
public const val BACKGROUND_IMAGE: String = "backgroundImage"
public const val BACKGROUND_SIZE: String = "experimental_backgroundSize"
public const val BACKGROUND_POSITION: String = "experimental_backgroundPosition"
public const val BACKGROUND_REPEAT: String = "experimental_backgroundRepeat"
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/components/view/BaseViewProps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ BaseViewProps::BaseViewProps(
: convertRawProp(
context,
rawProps,
"experimental_backgroundImage",
"backgroundImage",
sourceProps.backgroundImage,
{})),
backgroundSize(
Expand Down Expand Up @@ -403,7 +403,7 @@ void BaseViewProps::setProp(
switch (hash) {
RAW_SET_PROP_SWITCH_CASE_BASIC(opacity);
RAW_SET_PROP_SWITCH_CASE_BASIC(backgroundColor);
RAW_SET_PROP_SWITCH_CASE(backgroundImage, "experimental_backgroundImage");
RAW_SET_PROP_SWITCH_CASE_BASIC(backgroundImage);
RAW_SET_PROP_SWITCH_CASE(backgroundSize, "experimental_backgroundSize");
RAW_SET_PROP_SWITCH_CASE(
backgroundPosition, "experimental_backgroundPosition");
Expand Down
2 changes: 1 addition & 1 deletion ...components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ folly::dynamic HostPlatformViewProps::getDiffProps(
}

if (backgroundImage != oldProps->backgroundImage) {
result["experimental_backgroundImage"] = toDynamic(backgroundImage);
result["backgroundImage"] = toDynamic(backgroundImage);
}

if (mixBlendMode != oldProps->mixBlendMode) {
Expand Down
Loading
Loading