Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Relay Resolver compiler feature flag from the docs #4922

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bluegoo192
Copy link
Contributor

@bluegoo192 bluegoo192 commented Mar 1, 2025

On my machine and Relay v18.2.5, using this flag will cause an error and prevent the compiler from starting

Looks like it was removed here: 4e5377b

On my machine and Relay v18.2.5, using this flag will cause an error and prevent the compiler from starting

Looks like it was removed here: facebook@4e5377b
@captbaritone
Copy link
Contributor

We're in a tricky spot right now. The versioned docs here are for 18.0.0. The flag was removed after 18.0.0 (in a minor version). The flag is removed in the "Next" version of the docs. We don't currently have a good way to show API changes affecting minor versions in our docs.

If you want to update this to be a comment clarifying that the flag was removed since v18.0.0 that would be helpful! Otherwise we'll have to wait until v19

@bluegoo192 bluegoo192 closed this Mar 4, 2025
@bluegoo192 bluegoo192 reopened this Mar 4, 2025
@bluegoo192
Copy link
Contributor Author

thanks for the clarification! I totally didn't pay attention to when the change was released. Looks like it was in 18.1.0, updated to reflect that

Tbh I never checked the "Next" docs to see they were already updated, so if it's more trouble than it's worth to update these docs for a single version, I don't mind closing the PR either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants