Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MacOS resource classes in CircleCI config #11543

Closed
wants to merge 9 commits into from
Closed

Update MacOS resource classes in CircleCI config #11543

wants to merge 9 commits into from

Conversation

ltamasi
Copy link
Contributor

@ltamasi ltamasi commented Jun 15, 2023

Summary:
The large MacOS class on CircleCI is going away; the PR updates it to its recommended successor macos.m1.large.gen1.

Test Plan:
CI

@ltamasi
Update MacOS resource classes in CircleCI config
0370dd4 
Summary:
The `large` MacOS class on CircleCI is going away; the PR updates it to its
recommended successor `macos.m1.large.gen1`.

Test Plan:
CI
@facebook-github-bot
Copy link
Contributor

@ltamasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@adamretter adamretter self-requested a review June 15, 2023 18:30
adamretter
adamretter approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@facebook-github-bot
Copy link
Contributor

@ltamasi has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@ltamasi has updated the pull request. You must reimport the pull request before landing.

ajkr
ajkr approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@facebook-github-bot
Copy link
Contributor

@ltamasi has updated the pull request. You must reimport the pull request before landing.

@ltamasi
Copy link
Contributor Author

ltamasi commented Jun 16, 2023

Actually, it seems like there's more work needed here. Even after changing the Xcode version and installing Rosetta 2, we have one Java job that fails.

@ltamasi
Copy link
Contributor Author

ltamasi commented Jun 16, 2023 •
edited
Loading

Actually, it seems like there's more work needed here. Even after changing the Xcode version and installing Rosetta 2, we have one Java job that fails.

@adamretter Do you happen to have any advice w/r/t this build-macos-java failure? My guess is that it's somehow related to us currently running an x86 JDK8 on an M1 using Rosetta. Can we fix the script or should we switch to another/newer JDK? (IIUC there is no adoptopenjdk8 release for Apple Silicon.)

Exception in thread "main" java.lang.ExceptionInInitializerError
	at RocksDBSample.<clinit>(RocksDBSample.java:17)
Caused by: java.lang.RuntimeException: librocksdbjni-osx.jnilib was not found inside JAR.
	at org.rocksdb.NativeLibraryLoader.loadLibraryFromJarToTemp(NativeLibraryLoader.java:125)
	at org.rocksdb.NativeLibraryLoader.loadLibraryFromJar(NativeLibraryLoader.java:102)
	at org.rocksdb.NativeLibraryLoader.loadLibrary(NativeLibraryLoader.java:82)
	at org.rocksdb.RocksDB.loadLibrary(RocksDB.java:67)
	at org.rocksdb.RocksDB.<clinit>(RocksDB.java:36)
	... 1 more

@facebook-github-bot
Copy link
Contributor

@ltamasi has updated the pull request. You must reimport the pull request before landing.

@adamretter
Copy link
Collaborator

@ltamasi I'm on leave this week, but I can take a look in the following week if that's okay for you?

@ltamasi
Copy link
Contributor Author

ltamasi commented Jun 17, 2023

@ltamasi I'm on leave this week, but I can take a look in the following week if that's okay for you?

Thanks @adamretter ! Sure, we still have plenty of time before the currently used instance types go away.

@adamretter adamretter mentioned this pull request Jul 28, 2023
Closed
@alanpaxton alanpaxton mentioned this pull request Aug 18, 2023
Closed
@facebook-github-bot
Copy link
Contributor

@cbi42 merged this pull request in a9770b1.

@Zakelly Zakelly mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamretter adamretter adamretter approved these changes

@ajkr ajkr ajkr approved these changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ltamasi @facebook-github-bot @adamretter @ajkr