[Feature] Add per-agent advantage normalization support for IPPO/MAPPO - #256
Open
lmBored wants to merge 2 commits into
Open
[Feature] Add per-agent advantage normalization support for IPPO/MAPPO#256lmBored wants to merge 2 commits into
lmBored wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Author
|
@Xmaster6y it's a quick fix indeed. Can you review this change? |
Contributor
|
Small focused tests could be good. |
Author
|
I added 2 small tests to check the advantage calculation |
lmBored
added a commit
to Farama-Foundation/ViZDoom
that referenced
this pull request
Aug 2, 2026
The feature is not implemented in BenchMARL yet. It's opened under this PR: facebookresearch/BenchMARL#256
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #255