Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utils.py #17

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Update utils.py #17

merged 2 commits into from
Nov 7, 2024

Conversation

tkrulewich
Copy link
Contributor

Added deepcopy to SELF_TAUGHT_WITH_SYSTEM_PROMPT in prepare_vllm_input. Fixes bug due to global mutable list being modified. After first call datapoint, all subsequent output was identical.

Added deepcopy to SELF_TAUGHT_WITH_SYSTEM_PROMPT in prepare_vllm_input. Fixes bug due to global mutable list being modified. After first call datapoint, all subsequent output was identical.
@facebook-github-bot
Copy link

Hi @tkrulewich!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 31, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Golovneva Golovneva requested a review from xianxl November 1, 2024 14:07
@xianxl xianxl requested a review from uralik November 7, 2024 20:04
Copy link
Contributor

@uralik uralik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching! we did that minimal example and only tested with one-time inference =)

@uralik
Copy link
Contributor

uralik commented Nov 7, 2024

@tkrulewich could you please fix formatting? it says isort is not happy with the added import. isort --profile black $FILE should work

@tkrulewich
Copy link
Contributor Author

@tkrulewich could you please fix formatting? it says isort is not happy with the added import. isort --profile black $FILE should work

Sure thing. Updated the imports.

@uralik uralik merged commit f8f7617 into facebookresearch:main Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants