Replace deprecated logger.warn() with logger.warning()#5512
Open
Mr-Neutr0n wants to merge 1 commit into
Open
Conversation
logging.Logger.warn() has been deprecated since Python 3.2 in favor of logging.Logger.warning(). This commit replaces all 11 occurrences of logger.warn() across 5 files in the detectron2 package: - detectron2/evaluation/coco_evaluation.py - detectron2/evaluation/sem_seg_evaluation.py - detectron2/evaluation/lvis_evaluation.py - detectron2/data/datasets/coco.py - detectron2/engine/defaults.py Note: warnings.warn() calls (from the warnings module) are left unchanged as they are not deprecated.
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logging.Logger.warn()method withlogging.Logger.warning()across 5 files in the detectron2 package.Logger.warn()has been deprecated since Python 3.2 and is pending removal. It currently emitsDeprecationWarningin recent Python versions.warnings.warn()calls (from thewarningsmodule) are intentionally left unchanged, as they are not deprecated.Files changed
detectron2/evaluation/sem_seg_evaluation.pydetectron2/evaluation/coco_evaluation.pydetectron2/evaluation/lvis_evaluation.pydetectron2/data/datasets/coco.pydetectron2/engine/defaults.pyTest plan
logger.warn()calls in the codebasewarnings.warn()(stdlib) calls are unaffectedwarning()is the standard method with identical behavior