Remove fairseq2 AdamW #1084
Merged
Remove fairseq2 AdamW #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the AdamW optimizer from fairseq2. The main reason of having our own
AdamWoptimizer in fairseq2 (which was essentially using the sameadamwfunctional API as the PyTorch version) was to parity check fairseq's memory efficient fp16 optimizer. Since nowadays AMP and FSDP mixed precision training have become ubiquitous with almost always better model accuracy and minimal impact on memory, there is no need to maintain our own version. (Beyond fp16 becoming more and more obsolete compared to bf16 and lower-precision data types)