Refactor vocabulary info in recipes #1094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bundles three features:
vocab_info
fromSequenceModel
andSeq2SeqModel
and relies on the passed tokenizer to infer the vocabulary information.fairseq2.recipes.common
functions now expect as argument specific configuration sections instead of the general recipe configuration for better readability and mypy compatibility._add_
directive for configuration handling and extends_set_
to handle both adding and setting configuration keys. This also makes the logic consistent with_set_
being the equivalent ofdict[key] = value
and_del_
being the equivalent ofdel dict[key]
.