Disable the NEON optimisations on gcc <= 8 #3869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC7 doesnt support all the neccesary NEON intrinsics, which is really a shame. However this means that for aarch64 GCC cannot compile faiss with neon intrinsics, so we should avoid using them.
|
@JAicewizard this should not affect |
|
I just checked on CC explorer here and even with the oldest aarch64 clang there were no issues. So there might be an old clang compiler that doesn't work, but I am not in a position to test all of them. I suspect they were just always supported. |
|
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@JAicewizard we received bunch of errors internally. In case, you already know the issue before I look into it. |
|
This should be fixed now |
|
github action failed. @JAicewizard could you help fix them before I import again? Thanks! |
|
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
I pushed some changes, but I don't think they will fix the error on your end. If anyone could post them I can look into it |
JAicewizard
force-pushed
the
fix_gcc7_arm
branch
from
2d593e7
to
4d35936
Compare
|
@JAicewizard here is some errors. Thanks for your patience. |
|
@junjieqi Does this still occur? or only on the previous iteration. Currently there is no such code on line 62 so this should be fixed |
|
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
asadoughi
added a commit
that referenced
this pull request
Oct 7, 2024
Seeing if this changes the ARM CI run time to go back to under 1 hour, currently taking over 3 hours to run. This reverts commit 1ee7561.
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Oct 17, 2024
Summary: GCC7 doesnt support all the necessary NEON intrinsics, which is really a shame. However this means that for aarch64 GCC cannot compile faiss with neon intrinsics, so we should avoid using them. This is similar to facebookresearch#3860, build issues on GCC7, which I need. This one is a bit uglier, since GCC7 does support NEON just not all of the intrinsics. Pull Request resolved: facebookresearch#3869 Reviewed By: asadoughi Differential Revision: D63081962 Pulled By: junjieqi fbshipit-source-id: 69827cd447dd405b3ef70d651996f9ad00b6213e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC7 doesnt support all the necessary NEON intrinsics, which is really a shame. However this means that for aarch64 GCC cannot compile faiss with neon intrinsics, so we should avoid using them.
This is similar to #3860, build issues on GCC7, which I need. This one is a bit uglier, since GCC7 does support NEON just not all of the intrinsics.