Add support to multiple process groups by syncing across ranks #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengfukevin
requested review from
kingchc,
louisfeng,
sunghlin,
shengbao-zheng and
briancoutinho
as code owners
facebook-github-bot
added
the
CLA Signed
|
@shengfukevin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D60788539 |
shengfukevin
pushed a commit
that referenced
this pull request
Aug 5, 2024
Summary: Add support to multiple process groups by syncing across ranks. Pull Request resolved: #151 Test Plan: /usr/local/fbcode/platform010/bin/mpirun -np 2 path-to/comm_replay.par --trace-path param_bench/fb/integration_tests/resnet-2gpu --trace-type et Differential Revision: D60788539 Pulled By: shengfukevin
shengfukevin
force-pushed
the
shengf/fix-pg-create
branch
from
8e3bdb7
to
727f5fd
Compare
GSSBMW
reviewed
Aug 6, 2024
GSSBMW
reviewed
Aug 6, 2024
shengfukevin
pushed a commit
that referenced
this pull request
Aug 6, 2024
Summary: Add support to multiple process groups by syncing across ranks. Pull Request resolved: #151 Test Plan: /usr/local/fbcode/platform010/bin/mpirun -np 2 path-to/comm_replay.par --trace-path param_bench/fb/integration_tests/resnet-2gpu --trace-type et Differential Revision: D60788539 Pulled By: shengfukevin
|
This pull request was exported from Phabricator. Differential Revision: D60788539 |
shengfukevin
force-pushed
the
shengf/fix-pg-create
branch
from
727f5fd
to
573f91a
Compare
|
@GSSBMW, I converted the dictionary (loaded from json) between "str" to "str" to a dictionary between "int" to "str", keep the sort code. Please review it. Thanks |
TaekyungHeo
reviewed
Aug 6, 2024
TaekyungHeo
approved these changes
Aug 6, 2024
Summary: Add support to multiple process groups by syncing across ranks. Pull Request resolved: #151 Test Plan: /usr/local/fbcode/platform010/bin/mpirun -np 2 path-to/comm_replay.par --trace-path param_bench/fb/integration_tests/resnet-2gpu --trace-type et Reviewed By: briancoutinho Differential Revision: D60788539 Pulled By: shengfukevin
|
This pull request was exported from Phabricator. Differential Revision: D60788539 |
shengfukevin
force-pushed
the
shengf/fix-pg-create
branch
from
573f91a
to
457854c
Compare
|
@shengfukevin merged this pull request in c466b60. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support to multiple process groups by syncing across ranks.
Test Plan
$ comm_replay --trace-type et --trace-path /home/sanshang/021_debug/000_code/param/trace/traces_megatronlm_gpt_43B_32ranks_pytnightly0703/execution_trace