Change device but not dtype in UnitY2AlignmentModel#539
Open
d-dawg78 wants to merge 1 commit intofacebookresearch:mainfrom
Open
Change device but not dtype in UnitY2AlignmentModel#539d-dawg78 wants to merge 1 commit intofacebookresearch:mainfrom
d-dawg78 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
embs_text.size(1)orembs_unit.size(1)is large and the model's type istorch.float16, there are half-precision issues. This is easily reproducible locally:This causes downstream issues, especially in this line. We got the following error in production:
The following fix aims to make sure that there are no unnecessary
dtypeconversions in the code that could cause these size mismatch issues. We do however make sure that the device is changed if need be.