Skip to content

fix: migrate from keycode to code #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: migrate from keycode to code #49

wants to merge 1 commit into from

Conversation

AlessioGr
Copy link
Contributor

keycode is deprecated

@AlessioGr AlessioGr requested a review from jacobsfletch as a code owner June 17, 2023 23:16
@jacobsfletch
Copy link
Member

Can we check for both conditions instead of going all-in with only the newer API? This will will ensure there are no edge cases left behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobsfletch jacobsfletch Awaiting requested review from jacobsfletch jacobsfletch is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlessioGr @jacobsfletch