Adding a field_name to support existing entities #23
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d34dman
reviewed
Nov 30, 2020
Member
d34dman
left a comment
d34dman
left a comment
There was a problem hiding this comment.
This is a nice feature :) I would like to get this in! So lets see them tests :)
Member
|
This can be used to enforce "re-using" of fields too. Not sure if it would increase some bugs though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to provide a field_name to:
a.) Create fields without the field_ prefix
b.) hijack existing entities with fields which don't follow the current naming convention
Let me know what you think and I can add tests + documentation