Add separate AsyncReceiver type instead of implementing Future directly on the Receiver
#61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows removing many special cases where the receiver could previously be received on with non-async methods after it had been polled. I do not see any valid use case for polling a receiver, not getting a message, and then receive in some other way.
tisonkun
reviewed
May 30, 2025
| let channel = unsafe { self.channel_ptr.as_ref() }; | ||
|
|
||
| // Set the channel state to disconnected and read what state the receiver was in | ||
| match channel.state.swap(DISCONNECTED, Acquire) { |
There was a problem hiding this comment.
AsyncReceiver can observe UNPARKING state here?
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a separate type,
AsyncReceiver, that implementsFuture, instead of implementing it directly on theReceivertype. Now theReceiverimplementsIntoFutureinstead.This change removes the possible panics in many recv* methods, and it simplifies some code a bit.
This is a breaking change. So it is scheduled for the
0.2release.