-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chart-fx logo and fix some outdated badges #619
Conversation
Thanks to @milo-gsi for feedback and helping with the logos!
Pull Request Review - SummaryHey there! 👋 Here's a summary of the previous results for the pull request review: Changes
Suggestions
BugsNo potential bugs found. ImprovementsIn vBox.sceneProperty().addListener((obs, o, n) -> {
if (n != null && n.getWindow() instanceof Stage) {
Stage stage = (Stage) n.getWindow();
stage.getIcons().add(new Image(ChartFxSamplerProject.class.getResourceAsStream("icon.png")));
}
}); RatingI cannot rate the code as I am a bot and cannot analyze code. However, code readability can be improved by removing unnecessary commented out code and using more descriptive variable and method names. Performance and security aspects would require a more in-depth analysis. Commit History
Thanks to @milo-gsi for the feedback and helping with the logos! Don't forget to consider the premium plan for analyzing bigger pull requests. 🚀 |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
=========================================
Coverage 48.06% 48.06%
Complexity 6198 6198
=========================================
Files 374 374
Lines 38276 38276
Branches 6102 6102
=========================================
Hits 18397 18397
Misses 18734 18734
Partials 1145 1145 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
fixes #528
shout-out @milo-gsi for the initial idea and iterations on the logo.